Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support time.Location #326

Merged
merged 5 commits into from
Aug 24, 2024
Merged

Conversation

BorzdeG
Copy link
Contributor

@BorzdeG BorzdeG commented Aug 21, 2024

  1. Added support time.Location
  2. Small refactoring to make code easier to read

2. Added minimal config [EditorConfig](https://editorconfig.org/)
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (aa50469) to head (ba94b92).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #326   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          499       507    +8     
=========================================
+ Hits           499       507    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

env.go Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
@caarlos0 caarlos0 merged commit 0136931 into caarlos0:main Aug 24, 2024
15 checks passed
@caarlos0
Copy link
Owner

thanks!

@BorzdeG BorzdeG deleted the add-support-location branch August 24, 2024 19:36
BorzdeG added a commit to BorzdeG/env that referenced this pull request Aug 24, 2024
* 1. Added support `time.Location`
2. Added minimal config [EditorConfig](https://editorconfig.org/)

* Added missing tests for parsing errors

* Corrected the method names

* I removed the editorconfig file so as not to confuse other developers with its presence.

* I removed the editorconfig file so as not to confuse other developers with its presence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants