Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple tags at the same commit #40

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Conversation

caarlos0
Copy link
Owner

@caarlos0 caarlos0 commented Aug 3, 2021

closes #37

using git tag --sort=-version:refname with --merged as well if current-branch mode... matching is done using a glob library because git tag don't have that option.

on a test repo, it seemed to yield same results

e.g.

svu n --strip-prefix --prefix foo/ --pattern 'foo/*'

tests were still passing, changed them a bit to test multiple tag against the same commit as well

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Copy link

@fatih fatih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

@caarlos0 caarlos0 merged commit c26fb49 into master Aug 4, 2021
@caarlos0 caarlos0 deleted the multiple-tags branch August 4, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If the last tagged commit has multiple tags, svu should increment from the highest of those tags
2 participants