Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prepare helm chart for 0.3.0 #73

Merged
merged 12 commits into from
Jan 19, 2024
Merged

Conversation

niklastreml
Copy link
Contributor

Motivation

Since #69 added servicemonitors to the helm chart, we should also bump the chart version.

Changes

  • bumped chart version to 0.0.4

For additional information look at the commits.

@niklastreml niklastreml added bug Something isn't working docs Improvements or additions to documentation housekeeping area/helm Issues/PRs related to the helm chart labels Jan 16, 2024
@niklastreml niklastreml added this to the 0.3.0 milestone Jan 16, 2024
@niklastreml niklastreml self-assigned this Jan 16, 2024
@puffitos
Copy link
Member

Can the chart be deployed in its current state?

@eumel8
Copy link
Member

eumel8 commented Jan 16, 2024

panic: failed to read config file open tmconfig.yaml: no such file or directory

so, this is required?

@puffitos
Copy link
Member

panic: failed to read config file open tmconfig.yaml: no such file or directory

so, this is required?

We should release 0.0.3 and use that image for the chart. Once #65 is merged, we're good to go.

@niklastreml
Copy link
Contributor Author

I've bumped the charts appVersion to v0.3.0 to prepare for release

@lvlcn-t
Copy link
Member

lvlcn-t commented Jan 17, 2024

I've fixed a bug where the yaml couldn't be parsed if the service monitor is enabled but no labels were set.

Now values like this are vaild:

# -- Configure a service monitor for prometheus-operator
serviceMonitor:
  # -- Enable the serviceMonitor
  enabled: true
  # -- Sets the scrape interval
  interval: 30s
  # -- Sets the scrape timeout
  scrapeTimeout: 5s
  # -- Additional label added to the service Monitor
  labels: {}

@niklastreml
Copy link
Contributor Author

please look at #75, as that pr fixes e2e and allows us to properly test 0.3.0 internally

* feat: simplify helm chart

* fix: remove -n

* fix: register healthcheck for e2e test

* feat: separate checks and sparrow config

* fix: e2e tests

* fix: bug where env variables would not be read correctly

* feat: allow mounting extra secrets as env variables

* docs: envfromSecrets
@y-eight
Copy link
Contributor

y-eight commented Jan 18, 2024

Pls look at last 2 comments #75

@niklastreml
Copy link
Contributor Author

there is still a bug with marshalling env variables correctly, it is semi fixed in viper 1.18.0 but was hidden behind a feature flag in 1.18.2 due to causing a different bug. That bug only appears when using fun stuff like pointer pointers, so we should be fine I think.

spf13/viper#1429
spf13/viper#1715

@niklastreml niklastreml changed the title chore: updated helm chart version to 0.0.4 feat: Prepare helm chart for 0.3.0 Jan 18, 2024
Copy link
Member

@lvlcn-t lvlcn-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the chart work out-of-the-box without adjusting any values?

Currently that wouldn't be the case since the name and loader are mandatory:

$ helm upgrade sparrow chart/ -i --atomic --set image.tag=commit-b1dd2fc

Using config file: /config/.sparrow.yaml
{"time":"2024-01-18T19:08:59.750947469Z","level":"ERROR","source":{"function":"github.com/caas-team/sparrow/pkg/config.(*Config).Validate","file":"/home/runner/work/sparrow/sparrow/pkg/config/validate.go","line":40},"msg":"The name of the sparrow must be DNS compliant"}
{"time":"2024-01-18T19:08:59.751057558Z","level":"ERROR","source":{"function":"github.com/caas-team/sparrow/pkg/config.(*Config).Validate","file":"/home/runner/work/sparrow/sparrow/pkg/config/validate.go","line":47},"msg":"The loader http url is not a valid url"}
Error: error while validating the config: validation of configuration failed

...

error while validating the config: validation of configuration failed
Stream closed EOF for default/sparrow-75d554645d-ms8zq (sparrow)

I think we should still include required default configs to improve the user experience with this chart.

@niklastreml
Copy link
Contributor Author

added some defaults, that do nothing

Copy link
Member

@lvlcn-t lvlcn-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I'll do another PR for docs asap so we can release v0.3.0 today

@niklastreml niklastreml merged commit c4a6b54 into main Jan 19, 2024
11 checks passed
@lvlcn-t lvlcn-t deleted the chore/bump-chart-version branch January 19, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Issues/PRs related to the helm chart bug Something isn't working docs Improvements or additions to documentation housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants