Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Multiple Cabals Continuation #89
[RFC] Multiple Cabals Continuation #89
Changes from 34 commits
7d84c98
42cfbfe
c5880cb
d1cca36
eed7e4d
a535128
cf3f2fa
44e2fcf
be77795
3a7c66c
e13c9e1
0048df5
60d267e
506db67
18066be
9413cfd
02785a6
51672b9
cffa01f
49162b6
dfb3e61
7735dee
629e00b
3a03043
2b67983
92b04d8
a843f45
5989fa8
d1c0325
e3a8868
bb07285
3880a04
6462e30
2e83bd0
2e16401
502147b
dcf5958
8738a9e
253c00e
aadfdc7
8ce6dab
fb008b6
d4a55a5
7b66cfd
c6b2a01
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an implication of this is that if we make any protocol / network change, everyone in the cabalverse will use a new directory and have to generate a new private key (and lose all things associated to that identity. right now that's just "nick", but in the future it could be display pic or other things)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my feeling is to version this separately, or to not even version it at all. this is to try and escape from the vestigial hypercores, right? if our understanding of it is right, we should never have to do this again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, that only happens if we make a breaking change (major version). and if we make a breaking change, i think we should be free to rid ourselves of the headache of old configs and make the best of the breaking change.
this is definitely to try to pin down our issues. we should never need to do this, but if we do it then we can exclude for certain that old clients are screwing things up.
i am fine with trying out this approach for a while (after this pr is stable and merged) and then reverting to not using a protocol version if it still feels really bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're saying the same things:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌