PROTOCOL BREAKING: use discovery-swarm for sending peer key #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously 'swarm.js' would send a 32-byte payload before handing off to cabal-core#replicate. This
a) isn't necessary, since discovery-swarm can send an arbitrary payload anyway, and
b) makes other clients (like Message Land's gateway) unable to use straight-up cabal-core#replicate to sync with e.g. CLI peers
This also adds some tests for same-process and network sync, and makes the 'swarm' API be a member of the cabal instance instead of something to require separately.