Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives you:
subleveldown
. That it still worked onmemdb
was luck.readable-stream
)db.clear()
,db.iterator()
, promise support,iterator.seek()
memdown
internally stores data as buffers, which makes it fully compatible withleveldown
(mixing strings and buffers is OK now). There could be a perf boost here because values can skip aBuffer.from(string)
step but that's negated by a new conversion cost on keys (buf.toString()
).buffer: true
property to the custom JSON encoding used here. Not really needed because it defaults totrue
in most places, but it signals to underlying stores that data should be fetched as a buffer rather than a string, which avoids a conversion cost.Caveats:
null
andundefined
keys and values are rejectednull
andundefined
range options are now valid ({ gt: null }
is not the same as{}
).