unban+admin #80
unban+admin #80
Conversation
ghost
mentioned this pull request
| - `channel` (string, default="@") - the channel to ban the user from. `"@"` is cabal-wide. | ||
| - `reason` (string, default="") - reason for the banishment. |
|
|
||
| Valid `opts` include: | ||
|
|
||
| - `channel` (string, default="@") - the channel to ban the user from. `"@"` is cabal-wide. |
There was a problem hiding this comment.
does the underlying view allow adding a mod/admin for a single channel?
nitpick: says ban. same case for the next four segments containing channel
| this._modCmd('admin/remove', key, opts, cb) | ||
| } | ||
|
|
||
| Cabal.prototype._modCmd = function (type, key, opts, cb) { |
There was a problem hiding this comment.
i like this structure. i was considering something similar for parsing the extended moderation syntax in cabal-client
|
looks like the failing ci requires pushing |
|
I am very hesistant to make any changes to a package-lock in a PR. This creates automatic merge conflicts between any other open PRs. It also makes the patch very noisy and hard to read. |
|
cool, that makes sense. i'll try to remember to make that part of my workflow going forward, too |
There was a problem hiding this comment.
Yay! Excited to see this coming together. I'm going to close #78 in favour of getting this in.
| this._modCmd('admin/remove', key, opts, cb) | ||
| } | ||
|
|
||
| Cabal.prototype._modCmd = function (type, key, opts, cb) { |
| if (typeof key === 'string') return key.length === 64 && /^[0-9a-f]+$/.test(key) | ||
| else if (Buffer.isBuffer(key)) return key.length === 32 | ||
| if (typeof key === 'string') return /^[0-9a-f]{64}$/.test(key) | ||
| else if (Buffer.isBuffer(key)) return key.toString('hex').length === 32 |
| @@ -134,11 +187,16 @@ module.exports = function (cabal, modKey, db) { | |||
| }) | |||
| if (--pending === 0) cb(null, banned) | |||
| }) | |||
| }, | |||
|
|
|||
| getRole: function (core, opts, cb) { | |||
There was a problem hiding this comment.
Great API expansion! Do you have capacity to add these to the README docs as you go?
ghost
mentioned this pull request
|
closing in favor of #83 |
ghost
closed this
This patch builds on #78 and #77 and adds: