Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix litematica remapping error #4558

Closed
wants to merge 1 commit into from

Conversation

rfresh2
Copy link
Contributor

@rfresh2 rfresh2 commented Nov 18, 2024

fixes unimined not remapping schematicWorld.getBlockState to intermediary.

this PR should be merged forward, this issue is also present in 1.21.x

stacktrace:

[00:09:45] [Render thread/INFO]: [CHAT] [Baritone] > litematica
[00:09:45] [Render thread/INFO]: [CHAT] [Baritone] An unhandled exception occurred. The error is in your game's log, please report this at https://github.com/cabaletta/baritone/issues
...
[00:09:45] [Render thread/INFO]: [STDERR]: Caused by: java.lang.NoSuchMethodError: 'net.minecraft.class_2680 fi.dy.masa.litematica.world.WorldSchematic.getBlockState(net.minecraft.class_2338)'
[00:09:45] [Render thread/INFO]: [STDERR]: 	at baritone.utils.schematic.litematica.LitematicaHelper.getSchematic(LitematicaHelper.java:119)
[00:09:45] [Render thread/INFO]: [STDERR]: 	at baritone.process.BuilderProcess.buildOpenLitematic(BuilderProcess.java:237)
[00:09:45] [Render thread/INFO]: [STDERR]: 	at baritone.command.defaults.LitematicaCommand.execute(LitematicaCommand.java:39)
[00:09:45] [Render thread/INFO]: [STDERR]: 	at baritone.command.manager.CommandManager$ExecutionWrapper.execute(CommandManager.java:143)

@ZacSharp
Copy link
Collaborator

Mea culpa

Isn't WorldSchematic unused now?

@ZacSharp
Copy link
Collaborator

Wait, this isn't a problem in 1.19.4?

@rfresh2
Copy link
Contributor Author

rfresh2 commented Nov 18, 2024

ah, yeah just tested and it is also present on 1.19.4, i'll recreate this on that branch

i tested on 1.20.4, it wasn't present, and assumed 1.20.5 was the earliest

but looks like the last forward merge from 1.19.4 skipped to 1.20.5

@rfresh2 rfresh2 closed this Nov 18, 2024
@rfresh2
Copy link
Contributor Author

rfresh2 commented Nov 18, 2024

#4560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants