Return non zero exit code on errors for clean-svg-ids #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kesara can you give an example of a document where it's important to bubble up this failure as a critical failure? |
@dkg I don't have an example in hand. |
cabo
reviewed
Aug 22, 2024
| @@ -18,6 +18,7 @@ def svg_clean_ids(s) | |||
| rescue => detail | |||
| warn "*** Can't clean SVG: #{detail}" | |||
| d.to_s | |||
| exit 1 | |||
There was a problem hiding this comment.
This means there will be no output while the previous line was careful preparing to return something useful.
I'm not even sure that failing in this case warrants an exit code 1.
There was a problem hiding this comment.
Yeah, it makes sense not to exit with 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.