Bug on boolean values

[escobera]

Hello there,

I have a function similar to this one:

@decorate cacheable(cache: MyCache, key: id)
def good?(id) do
  HttpClient.get() 
  |> handle_response()
end

When this function returns false, even though the value gets cached, the next time it is called it won't use the cached value and issue another http request.

I tracked down the problem to this code:

nebulex/lib/nebulex/caching.ex

Lines 481 to 484 in 7dcdd30

	if value = cache.get(key, opts) do
	value
	else
	Caching.eval_match(unquote(block), match, cache, key, opts)

Problem here is if cache.get(key, opts) evals to false (this is my case) this line value = cache.get(key, opts) evals to false, you can test in iex with:

iex(1)> x = false
false

Since this is not a pure function and the value gets cached I wasn't able to make a failing test case for it, but it seems that to fix this you can change those lines to:

case cache.get(key, opts) do
  nil -> Caching.eval_match(unquote(block), match, cache, key, opts)
  value -> value
end

I ran the tests here after the change and they pass.

[cabol]

Thanks for report the issue, question, would you like to send a PR with the fix? Otherwise, NP, I can take a look at it and apply the fix. Let me know, stay tuned! Thanks again!

[escobera]

I'm trying to come up with a test case for it. I'll send the PR as soon as possible.

[cabol]

The PR LGTM! It is merged, I will publish a new release this weekend! Thank you for fixing the issue 👍 !!