Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling cacheable() method when cached value is false #112

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Avoid calling cacheable() method when cached value is false #112

merged 2 commits into from
Apr 8, 2021

Conversation

escobera
Copy link
Contributor

@escobera escobera commented Apr 8, 2021

ref issue #111

I tested the side effect using another cache key on the same cache, any feedback is more than welcome =)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1a35eb9 on escobera:master into 7dcdd30 on cabol:master.

@cabol cabol merged commit 2929c42 into cabol:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabol cabol cabol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@escobera @coveralls @cabol