Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay flushing ets table to avoid blocking processes using it #210

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Delay flushing ets table to avoid blocking processes using it #210

merged 3 commits into from
Jul 14, 2023

Conversation

szajbus
Copy link
Contributor

@szajbus szajbus commented Jul 14, 2023

This PR fixes #197. We've been successfully using this for about 3 months now.

Adding new option to Nebulex.Adapters.Local:

    * `:gc_flush_delay` - If it is set, an integer > 0 is expected defining the
      delay in milliseconds before objects from the oldest generation are
      flushed. Defaults to `10_000` (10 seconds).

cabol
cabol approved these changes Jul 14, 2023
View reviewed changes
Copy link
Owner

@cabol cabol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE 👍 !!!

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling e80690c on team-telnyx:gc-flush-delay into 974f54e on cabol:master.

@cabol cabol merged commit 730d645 into cabol:master Jul 14, 2023
4 checks passed
@szajbus szajbus deleted the gc-flush-delay branch July 17, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabol cabol cabol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Processes reading from cache blocked by generational gc process
3 participants
@szajbus @coveralls @cabol