Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch docker-compose.yml to use pgsql #11

Merged
merged 1 commit into from
Oct 7, 2015
Merged

Switch docker-compose.yml to use pgsql #11

merged 1 commit into from
Oct 7, 2015

Conversation

djdefi
Copy link
Contributor

@djdefi djdefi commented Aug 28, 2015

Change to docker-compose.yml to utilize postgresql instead of MySQL. Does not require immediately updating docs, since MySQL will still work fine also.

Closes #2

@djdefi
Copy link
Contributor Author

djdefi commented Aug 28, 2015

ping @cachethq/docker

@djdefi djdefi self-assigned this Aug 28, 2015
@n0mer
Copy link

n0mer commented Aug 28, 2015

@rtrauntvein so what exactly do you want

and why do you change to pgsql

@djdefi
Copy link
Contributor Author

djdefi commented Aug 28, 2015

Just looking for review of the PR.

This is based on suggestion of using Postgres instead of MySQL by @GrahamCampbell or @jbrooksuk

@GrahamCampbell
Copy link
Contributor

and why do you change to pgsql

Because it's way better than mysql. ;P

@n0mer
Copy link

n0mer commented Aug 28, 2015

it is less popular , according to http://db-engines.com/en/ranking

image

@GrahamCampbell
Copy link
Contributor

it is less popular

Doesn't mean it's not better.

@jbrooksuk
Copy link
Member

In our experience - with StyleCI - MySQL has a lot of quirks that we can avoid.

@n0mer
Copy link

n0mer commented Aug 28, 2015

i would quote Donald E. Knuth here, "premature optimization is root of all evil".

If your users demand this - fine. If it solves some problem that already exists in Cachet - also fine.

If this to show off your personal taste - you're on your own :)

@n0mer
Copy link

n0mer commented Aug 28, 2015

@rtrauntvein as for PR itself - why did you change data-only container to the folder on host machine?

@djdefi
Copy link
Contributor Author

djdefi commented Aug 28, 2015

There was no data volume or data only container for persistence of the Database before.

Sent from my iPhone

On Aug 28, 2015, at 2:39 AM, Nikolay Gorylenko notifications@github.com wrote:

@rtrauntvein as for PR itself - why did you change data-only container to the folder on host machine?


Reply to this email directly or view it on GitHub.

@n0mer
Copy link

n0mer commented Aug 28, 2015

@rtrauntvein you are right, no volumes for compose. You just hardcoded the path on host machine, that this "compose" script will demand.

@djdefi
Copy link
Contributor Author

djdefi commented Aug 28, 2015

The directory would get created automatically, but I will just take it out.

@GrahamCampbell
Copy link
Contributor

Any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants