Add some restart tests #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First pass at a refactor of init detection. Have only tested so far with Postgres, and will need to setup better tests to cover MySQL a bit more. |
…rt-tests * 'restart-tests' of github.com:CachetHQ/Docker: MAX_CHILDREN changed to PHP_MAX_CHILDREN Added environment setup for pm.max_children, default:5
djdefi
commented
Mar 14, 2017
| APP_ENV=${APP_ENV:-development} | ||
| APP_DEBUG=${APP_DEBUG:-true} | ||
| APP_URL=${APP_URL:-http://localhost} | ||
| APP_KEY=${APP_KEY:-SECRET} | ||
| APP_KEY=${APP_KEY:-base64:SGZXUdds0Qnbf55/7diaHMPPM2TXfOSxHtUAXz6POSw=} |
There was a problem hiding this comment.
I realize a key is being shipped here, but it needed some real default value for now. This should be set via -e APP_KEY="base64:<Your Real Key>" in production anyway.
|
cc: @csandanov based on #161 (comment) |
This was referenced Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some tests for restart behavior. The goal is to have something better for restart detection than the
.cachet-installedlogic inentrypoint.shref: #161 (comment)