Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PgSQL default #78

Merged
merged 2 commits into from
May 25, 2016
Merged

Use PgSQL default #78

merged 2 commits into from
May 25, 2016

Conversation

jbrooksuk
Copy link
Member

I think this is right? It's untested.

djdefi
djdefi reviewed May 25, 2016
View reviewed changes
docker/entrypoint.sh
DB_DRIVER=${DB_DRIVER:-mysql}
DB_HOST=${DB_HOST:-mysql}
DB_DRIVER=${DB_DRIVER:-pgsql}
DB_HOST=${DB_HOST:-127.0.0.1}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should default to postgres rather than 127.0.0.1 as we have name the postgres container and setup a Docjer link to the Cachet container in https://github.com/CachetHQ/Docker/blob/master/docker-compose.yml#L16

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@djdefi djdefi merged commit ce53cd7 into master May 25, 2016
@jbrooksuk jbrooksuk deleted the jbrooksuk-patch-1 branch May 25, 2016 17:22
djdefi added a commit that referenced this pull request May 27, 2016
@djdefi
Use PgSQL default (#78) (#79)
0e2db7d 
* Use PgSQL default

* change DB_HOST default
djdefi added a commit that referenced this pull request May 27, 2016
@djdefi
Use PgSQL default (#78) (#79) (#80)
a512ce3 
* Use PgSQL default

* change DB_HOST default
djdefi added a commit that referenced this pull request May 27, 2016
@djdefi
2.3 Image enhancements (#82)
6de3691 
* Use PgSQL default (#78) (#79)

* Use PgSQL default

* change DB_HOST default

* Image enhancements and best practices

* Set to master version

* enable cachet_ver ARG for build time version override
@dtpest dtpest mentioned this pull request Jul 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@djdefi djdefi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrooksuk @djdefi