Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Travis disable xdebug #2056

Merged
merged 2 commits into from
Aug 13, 2016
Merged

Make Travis disable xdebug #2056

merged 2 commits into from
Aug 13, 2016

Conversation

ConnorVG
Copy link
Contributor

This makes the tests run much quicker as composer install is fifty million times faster.

@GrahamCampbell
Copy link
Contributor

I tried this before and there was zero difference. Let's see what happens this time.

@ConnorVG
Copy link
Contributor Author

ConnorVG commented Aug 13, 2016

mr travis no likey

(hhvm / 7.1, that is)

@ConnorVG
Copy link
Contributor Author

Though the tests were much quicker.

@ConnorVG
Copy link
Contributor Author

I wonder why 7.1 and hhvm don't work: The command "phpenv config-rm xdebug.ini" failed and exited with 1 during .

Strange!

@GrahamCampbell
Copy link
Contributor

Xdebug doesn't support PHP 7.1 yet, so it's not installed there. :)

@ConnorVG
Copy link
Contributor Author

Still, I didn't really expect it to error just because the config didn't exist. Maybe a warning but not an error. That's fine though, just test against it's version.

@GrahamCampbell GrahamCampbell merged commit 2348bdb into cachethq:2.4 Aug 13, 2016
@ConnorVG ConnorVG deleted the travis-xdebug-config branch August 13, 2016 16:05
@GrahamCampbell
Copy link
Contributor

Thx. :P

@GrahamCampbell GrahamCampbell added this to the V2.4.0 milestone Aug 13, 2016
@ConnorVG
Copy link
Contributor Author

What a savage

image

@GrahamCampbell
Copy link
Contributor

Hahaha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants