Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to only show disrupted days #2136

Merged
merged 1 commit into from
Oct 4, 2016
Merged

Option to only show disrupted days #2136

merged 1 commit into from
Oct 4, 2016

Conversation

jbrooksuk
Copy link
Member

Closes #2088


The timeline can now optionally show only days which were disrupted — those that has an incident.

This setting continues to be false by default.

@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Oct 4, 2016
@jbrooksuk jbrooksuk self-assigned this Oct 4, 2016
@jbrooksuk jbrooksuk merged commit 5b2d99e into 2.4 Oct 4, 2016
@jbrooksuk jbrooksuk deleted the only-disrupted-days branch October 4, 2016 19:52
@TheoBearman
Copy link
Contributor

This doesn't appear to reset the setting when the tickbox is checked and unchecked. Having checked the box and the unchecked it again (saving each time) the timeline is still only showing the days where there have been incidents.

@GrahamCampbell
Copy link
Contributor

make sure bootstrap/cachet is writable please

@TheoBearman
Copy link
Contributor

It is. Makes no difference.

@jbrooksuk
Copy link
Member Author

It's only like any other setting? Do they work for you?

@TheoBearman
Copy link
Contributor

Other options, for example, Show Support for Cachet? don't seem to be working either. I've double checked that the folder @GrahamCampbell quoted above is writable and it is.

@ConnorVG
Copy link
Contributor

ConnorVG commented Oct 6, 2016

Very strange, @TheoBearman, this feature seems to be working everywhere I have checked it.

Have you attempted to clear out your caches? You can do this manually by:

  • Deleting all PHP files in bootstrap/cache
  • Deleting all PHP files in bootstrap/cachet

Before refreshing your page, please ensure the setting is definitely as you would like it to be in the config file. Let me know if this helps 😄

@TheoBearman
Copy link
Contributor

@ConnorVG That didn't work either. I'm going to make a fresh install when I get home from a work trip tomorrow and report back.

@ConnorVG
Copy link
Contributor

ConnorVG commented Oct 6, 2016

@TheoBearman thanks, I'll eagerly await!

sits patiently 😂

@TheoBearman
Copy link
Contributor

TheoBearman commented Oct 7, 2016

Did a fresh install and the setting is still not working.

Just getting more and more bizarre. All permissions are correctly set. Even when I manually set it the setting to false in setting.php, this is not reflected on the dashboard.

See here - I can make an admin user for you guys to use if requested, just drop me an email.

@jbrooksuk
Copy link
Member Author

@TheoBearman can you email me a dump of your database. I know what's happening here, but I don't know the best solution.

The issue is caused by you having unresolved incidents after introducing updates. This may be more of a UX issue than anything.

@TheoBearman
Copy link
Contributor

@jbrooksuk I realised that when the dashboard said Some systems are experiencing issues when all of my components were Operational. I went back and changed all of the past incidents to resolved but that still does not fix the issue with the settings.

I will email you my DB anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants