-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api groups order #2138
Api groups order #2138
Conversation
Update from upstream repo CachetHQ/Cachet
Update from upstream repo CachetHQ/Cachet
Issue: if the request use “?sort=order” returns groups ordered by “order DESC”. This is unexpected. If I would a reversed order I have to use “sort=order&order=desc”
One thing we should add is multiple sorts. Fancy this @billmn? |
@jbrooksuk Multiple sorts can introduce some BC but I think we can remove the "order" parameter using only "sort":
|
I like it, but this breaks BC and I don't like that. |
I agree with what @jbrooksuk said but I also have a question... What would be the 'default' definition for the sort orders if you're wanting it to go this way? Seems both opinionated and random to me. |
@jbrooksuk I agree too, nobody loves BC :) @ConnorVG If I don't specify the "sort" parameter I use a default sorting (eg: for component groups -> status DESC, order ASC). If I specify the "sort" parameter:
|
I see, I didn't notice the hyphen. Thanks. |
I guess we have to break BC on something like this? |
We don't have to, especially if we use a versioned API. |
True. Although that's a ball ache to maintain. |
🤔 💭 |
Issue: if the request use “?sort=order” returns groups ordered by “order DESC”.
This is unexpected.
If I would a reversed order I have to use “sort=order&order=desc”