-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No data available status #2194
No data available status #2194
Conversation
Hmm, I like the idea of having an almost indeterminate status, but I don't know if I like the "No data available" status. Actually, under what circumstances would you have no data? |
Some monitorings use the "unkown" status if they can't get informations about the service health from the monitoring client. Nagios as example use it :-) If you use cachet as a internal status Page it can be helpful to have it to see that something is going wrong. if you match it hard to "down" and the service isn't really down so you have a status between down and up. |
Well, for example, we query our components statuses not by hitting them directly but querying a central log application.
So, in our case, having no information in the logs doesn't mean anything about a component status. What we are looking for is a way to say that is not possible to define the status of the component. |
Okay, thanks for providing a better explanation. I think I prefer "Unknown". Thoughts? Ping @CachetHQ/core. |
Yes, it sounds better "Unknown". |
Okay and two more points here:
|
If I'm not mistaken, the test that failed is not related to the changes on this branch. |
Can you squash into one commit, please? We have a commit adding languages, then removing them. I'll check that this does everything we expect on Sunday :) |
ab63b02
to
73f4920
Compare
Done. Sorry about that. It's my first time with Cachet, Laravel, Github as issue tracker, etc. I hope my next pull request be cleaner :) |
Can you rebase this please? We changed some stuff in the Laravel upgrade. Once debased we will merge this immediately. |
73f4920
to
b223da9
Compare
Done |
We added a new status for the components, "No Data Available". This doesn't seem meaningful for manual modifications, but when components are regularly updated through Cachet API, it's pretty useful to have it.
If it's not desirable, my apologies and just cancel the pull request :)