Skip to content

Commit

Permalink
draft: add comments to process-compose settings issues
Browse files Browse the repository at this point in the history
  • Loading branch information
sandydoo committed Apr 22, 2024
1 parent 150edde commit 3b76a5c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions src/modules/process-managers/process-compose.nix
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ in
settings = lib.mkOption {
type = settingsFormat.type;
default = { };
# TODO: the description and example are incorrect. AFAIKT this is the top-level config.
description = ''
process-compose.yaml specific process attributes.
Expand All @@ -37,6 +38,7 @@ in
};
};
config = lib.mkIf cfg.enable {
# TODO: PC_TUI_ENABLED doesn't exist? PC_DISABLE_TUI does
processManagerCommand = ''
${cfg.package}/bin/process-compose --config ${cfg.configFile} \
--unix-socket ''${PC_SOCKET_PATH:-${toString config.process.process-compose.unix-socket}} \
Expand All @@ -51,7 +53,11 @@ in
settings = {
version = "0.5";
is_strict = true;
# TODO: not a process-compose setting
# TODO: never used in command
port = lib.mkDefault 9999;
# TODO: not a process-compose setting
# TODO: never used in command. process.process-compose.tui is.
tui = lib.mkDefault true;
environment = lib.mapAttrsToList
(name: value: "${name}=${toString value}")
Expand Down
2 changes: 1 addition & 1 deletion src/modules/processes.nix
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ in
default = true;
};
unix-socket = lib.mkOption {
type = types.str;
type = types.str; # TODO: should be path?
description = "The path to the Unix socket.";
default = "${config.devenv.runtime}/pc.sock";
defaultText = lib.literalExpression "\${config.devenv.runtime}/pc.sock";
Expand Down

0 comments on commit 3b76a5c

Please sign in to comment.