Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/rubyonrails: make test pass #1089

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

bobvanderlinden
Copy link
Contributor

@bobvanderlinden bobvanderlinden commented Apr 1, 2024

The tests now seem to run inside a pure environment and tests were failing with strange errors.

Initially I worked through the gem install rails failures by installing the failing gems individually. This worked, but lead me to a failure from railties which required git to be available. After adding git, it seemed that installing the individual gems wasn't needed anymore, so I removed those statements. Let's 🤞 something in my environment hasn't made the test succeed by accident.

Lastly, the test itself uses curl to fetch the version from rails, so this package is also added.

I tested this using:

git clean -xdf examples/ && nix build && PATH=$PWD/result/bin:$PATH ./result/bin/devenv-run-tests 
--only rubyonrails examples

Just a side-note: I'm still somewhat unsure about the process-manager that runs inside the test. It exists after devenv-run-tests exits. Left-over processes might potentially influence other things.

@domenkozar domenkozar merged commit e106743 into cachix:main Apr 1, 2024
67 of 247 checks passed
@totoroot totoroot mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants