Fix: sync nodejs versions #1202
Conversation
| @@ -218,7 +218,7 @@ in | |||
| ] | |||
| ++ lib.optional cfg.npm.enable (cfg.npm.package) | |||
| ++ lib.optional cfg.pnpm.enable (cfg.pnpm.package) | |||
| ++ lib.optional cfg.yarn.enable (cfg.yarn.package) | |||
| ++ lib.optional cfg.yarn.enable (cfg.yarn.package.override { nodejs = cfg.package; }) | |||
There was a problem hiding this comment.
do we also need this for pnpm?
There was a problem hiding this comment.
Yea pnpm has the same problem but this override only works because yarn package supports it. Pnpm is a nodePackage which sadly doesn't support this (same problem if you would use nodePackage.yarn instead of yarn)
There was a problem hiding this comment.
Only way I found to fix that was using overlay to fix all nodejs to specific version
There was a problem hiding this comment.
Underlying nix issue: NixOS/nixpkgs#145634
There was a problem hiding this comment.
Something like this also works: cfg.package.pkgs.pnpm. This installs pnpm with the correct node version, but not sure if all node pkgs support this (tested with pkgs.nodejs_21;), will do some more testing.
There was a problem hiding this comment.
Doesn't work with nodejs-slim pkg so not sure what the best way forward is here. Supporting overlays seems like the only way to support all different pkgs.
There was a problem hiding this comment.
Commented workarounds in original issue aswel so people can still use this until a proper fix is ready. Do you reckon moving away from slim nodejs is a good solution?
This fixes yarn using a different nodejs version (partially solves #637). This doesn't work if yarn pkg is a
nodePackage. Pnpm also has the same problem since it's anodePackage, not sure how to fix that, seems to use the first node version that is installed.