ci: fix failing tests #1248
Merged
ci: fix failing tests #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying devenv with
|
| Latest commit: |
5a3b934
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ade4f31b.devenv.pages.dev |
| Branch Preview URL: | https://fixup-tests.devenv.pages.dev |
sandydoo
force-pushed
the
fixup-tests
branch
3 times, most recently
from
5318690
to
1577956
Compare
|
thinking about it some more, the |
|
Alright, I'm out of steam. The last two failures are on macOS.
|
domenkozar
reviewed
Jun 9, 2024
devenv-run-tests/src/main.rs
Outdated
| .args(devenv_override) | ||
| .args(overrides.clone()) | ||
| .arg("shell") | ||
| .arg("./.setup.sh") |
There was a problem hiding this comment.
So this is the same as enterShell, but it's not racy so that's why it works better?
There was a problem hiding this comment.
Exactly. The problem we have now is that this sets things up in .devenv, but then devenv test uses a temporary directory. We can work around this by librarifying devenv and setting up our own temp dir.
|
Needs #1263. |
sandydoo
force-pushed
the
fixup-tests
branch
4 times, most recently
from
7bf30ec
to
a35e90e
Compare
Bind the collector to localhost to avoid triggering the firewall on macOS.
- Fix `devenv search` pattern matching - Skip container tests on macOS. Not supported at the moment.
Use `.patch.sh` to run setup before the shell is launched. This is useful to create or patch devenv.nix files. `.setup.sh` now runs inside the shell to allow access to packages. This mimics running commands manually as the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed examples:
won't launch onmacos-13. firewall issue? Tried disabling firewall, still nada.the readiness_probe on clickhouse is broken on macos13. curl-ing against the http port works. Only happens in GHA 🤷
clickhouse-clientworks as expected.odinneeds nixpkgs bump for darwin fixes.unison-ucmdoesn't have aarch64-linux builds.Fixed languages:
gdbandolsoptional depending on system.Broken tests:
devenv-test-clidevenv testtests/mysqlfails on macosOther changes:
.setup.shto run inside the devenv shell. This helps test manual user setup, like initializing a project and installing dependencies..patch.shscript support indevenv-run-tests. This runs outside of the shell, before.setup.sh. This should be used to patch files, likedevenv.nix.example.comwithlocalhost.