Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Just Command Runner and Treefmt-nix; Fix Minor Bugs #1291

Closed
wants to merge 51 commits into from

Conversation

use-the-fork
Copy link
Contributor

@use-the-fork use-the-fork commented Jun 21, 2024

This pull request introduces the Just command runner and Treefmt-nix, and includes fixes for several minor bugs.

Key Additions:

  1. Just Command Runner:

    • Implements the Just command runner for seamless script integration.
    • Integrates with pre-commit, treefmt-nix, devenv up, and version.
    • Includes sample Just scripts for initial use and further development.
    • Adds the default justfile, which imports just.flake into REQUIRED_FILES for proper setup.
    • Updates documentation to include new options and settings for the Just command runner.
  2. Treefmt-nix:

    • Integrates Treefmt-nix into devenv.
    • Updates documentation to detail the Treefmt-nix configuration and usage.
  3. Development Environment Updates (devenv.nix):

    • Enhances the build process for documentation to avoid npx dependencies by using Nix's pkgs.tailwindcss package.

Issues Addressed:

@use-the-fork
Copy link
Contributor Author

Let me know if there is anything you all need me to do with this module. I added docs and tests today.

@use-the-fork use-the-fork changed the title Add Just to Scaffold Command, Enhance Development Environment, and Bug Fixes Add Just Command Runner and Treefmt-nix; Fix Minor Bugs Jun 24, 2024
@use-the-fork
Copy link
Contributor Author

@domenkozar I'm not sure if I did everything you need to merge this. Just so you know, I use AI to help write the PR and commit messages. I do all the coding myself but AI does a better job at making my documentation clear :)

@I-Want-ToBelieve
Copy link

@domenkozar

@use-the-fork
Copy link
Contributor Author

@sandydoo @domenkozar I'm very pleased with the current integration after today's refactor, which streamlined the just runner. I have other integrations ready in a separate branch for a PR, but I prefer to get this merged first. I understand it's a significant change and am eager to assist in any way needed.

So let me know thanks!

@domenkozar
Copy link
Member

Hey, can you split this PR into separate ones for each issue? That way it makes it easier to review.

@use-the-fork use-the-fork marked this pull request as draft July 3, 2024 21:31
@domenkozar domenkozar closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print version information when entering shell Integrate treefmt-nix Adding commands to devenv
4 participants