python: Enter directory when creating venv #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like |
This commit does several things in one go: 1. Fixes `libstdc++.so.6` issues due to poetry using unwrapped Python when used in combination with `languages.python.directory`. This was because the `poetry env use` wasn't given the source directory. 2. Fixes poetry creating incorrect shebangs because `languages.python.directory` is a relative path. This is a known issue: python-poetry/poetry#9415 3. Cleans up the bash code by using pushd/popd.
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things in one go:
Fixes
libstdc++.so.6issues due to poetry using unwrapped Python when used in combination withlanguages.python.directory. This was because thepoetry env usewasn't given the source directory.Fixes poetry creating incorrect shebangs because
languages.python.directoryis a relative path. This is a known issue:poetry -C path/to/project add packageinstalls package with relative path to python interpreter python-poetry/poetry#9415Cleans up the bash code by using pushd/popd.
I am a bit uncertain about the use of
pushd/popd. It'd be nice to use them, but they can be replaced with a local variable.