Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Root user password assignment in MySQL and MariaDB #1345

Merged
merged 2 commits into from
Jul 28, 2024

Conversation

k3yss
Copy link
Collaborator

@k3yss k3yss commented Jul 27, 2024

This PR addresses an issue in MySQL or MariaDB where attempts to assign a password to the root user are unsuccessful, resulting in the default blank password being used.

Fixes #1251

@k3yss k3yss changed the title fix: Root user password assignment fix: Root user password assignment in MySQL and MariaDB Jul 27, 2024
@domenkozar
Copy link
Member

@YSawc can you try this branch?

@YSawc
Copy link

YSawc commented Jul 28, 2024

@domenkozar
I'm new comer of devenv project, so my confirmation way may not right but, after checkout this branch and build after comnad of direnv allow ., it seems resolved root password bug. Is this right way? If it's so, this PR looks no probrem.

@k3yss
Copy link
Collaborator Author

k3yss commented Jul 28, 2024

@YSawc Did you do this https://devenv.sh/community/contributing/

@YSawc
Copy link

YSawc commented Jul 28, 2024

@YSawc Did you do this https://devenv.sh/community/contributing/

I just done it and after devenv up below devenv.nix, mysql password applied root user. Thanks your fix.

...
  services.mysql = {
    ..
    ensureUsers = [
      {
        name = "root";
        password = "[PASSWORD]";
        ...
      }
    ];
  };

@domenkozar domenkozar merged commit 50da41d into cachix:main Jul 28, 2024
268 of 275 checks passed
@k3yss k3yss deleted the work/keys/mysql-root-fix branch July 29, 2024 03:30
@JoeDupuis
Copy link

JoeDupuis commented Sep 29, 2024

This breaks trying to create a user without a password: #1443

Setting an empty password is a workaround, but we should support the default value (null) without crashing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MYSQL ensureusers password doesn't work, unable to login to mysql
4 participants