feat: Documentation improvements #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying devenv with
|
| Latest commit: |
bbefd79
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e983c585.devenv.pages.dev |
| Branch Preview URL: | https://work-keys-doc-improvement.devenv.pages.dev |
k3yss
force-pushed
the
work/keys/doc-improvement
branch
from
15e9469
to
0a72193
Compare
sandydoo
requested changes
Aug 12, 2024
flake.nix
Outdated
Comment on lines
117
to
120
| pkgs.stdenv.mkDerivation { | ||
| name = "generate-individual-docs"; | ||
| src = ./.; | ||
| buildPhase = '' |
There was a problem hiding this comment.
Not really important, just suggestions:
runCommandis a common helper for derivations like these.- If you don't need the entire source, you can set
src = ./docsto avoid copying the entire source to the store.
There was a problem hiding this comment.
I tried using runCommand and I don't think it handles the src attributes gracefully:
https://discourse.nixos.org/t/using-the-src-attribute-in-runcommand/19329
fix: Fix filterOptions.nix and doc generation
k3yss
force-pushed
the
work/keys/doc-improvement
branch
from
8fe7cdd
to
0de4d5d
Compare
k3yss
force-pushed
the
work/keys/doc-improvement
branch
from
1e466d0
to
96f6c41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the UX with the current documentation of devenv.sh, this PR does:
languages,services,processes-managersandintegrations(todo)docs/individual-docsresolves #674