Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added custom option and config #1368

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

ElrohirGT
Copy link
Contributor

This PR resolves (#1212) by adding a configuration option that enables the user to start the PostgreSQL server with a custom pg_hba.conf file, this file is primarily used to enable or disable which IPs get to connect to the server both locally (from UNIX sockets) or from the network (using TCP/IP).

I had a "Fine I'll do it myself moment" and honestly after I saw the code it wasn't really that hard.

@domenkozar
Copy link
Member

I had a "Fine I'll do it myself moment" and honestly after I saw the code it wasn't really that hard.

💪 💪 💪

src/modules/services/postgres.nix Outdated Show resolved Hide resolved
src/modules/services/postgres.nix Outdated Show resolved Hide resolved
src/modules/services/postgres.nix Outdated Show resolved Hide resolved
@domenkozar
Copy link
Member

Need to run pre-commit run -a.

@ElrohirGT
Copy link
Contributor Author

Need to run pre-commit run -a.

How do I install the pre-commit hooks? I tried running nix develop --impure and nix develop, both enter me in a devShell but none install the hooks.

@domenkozar
Copy link
Member

That's strange. You cab just run nixpkgs-fmt on the file you change as a workaround

@ElrohirGT
Copy link
Contributor Author

Gotcha! There's two nixfmt on the store, I tried both. Decided on the one with the less amount of changes to the rest of the file.

@domenkozar
Copy link
Member

We're using nixpkgs-fmt

@ElrohirGT
Copy link
Contributor Author

We're using nixpkgs-fmt

haha gotcha, I'm dumb, I thought you were refering to nixfmt. Fixed it! Now it should be on the correct format.

@ElrohirGT
Copy link
Contributor Author

Hmmm... weird. I don't know why the tests fail on Mac ARM-64 but I can confirm that using this code I can run it successfully on my project.

@domenkozar
Copy link
Member

I believe that's an error on our side.

@domenkozar domenkozar merged commit 97e674b into cachix:main Aug 19, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants