Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process-compose: fix running processes with is_elevated #1404

Merged
merged 1 commit into from
Aug 27, 2024
Merged

process-compose: fix running processes with is_elevated #1404

merged 1 commit into from
Aug 27, 2024

Conversation

sandydoo
Copy link
Member

Fixes #1391.

@sandydoo sandydoo added the bug Something isn't working label Aug 27, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying devenv with  Cloudflare Pages  Cloudflare Pages

Latest commit: d042988
Status: ✅  Deploy successful!
Preview URL: https://421f836f.devenv.pages.dev
Branch Preview URL: https://support-pc-is-elevated.devenv.pages.dev

View logs

@sandydoo sandydoo marked this pull request as ready for review August 27, 2024 12:48
@domenkozar domenkozar merged commit 1e4ef61 into main Aug 27, 2024
19 of 20 checks passed
@RafaelKr
Copy link
Contributor

@sandydoo is this or false actually required?

@sandydoo
Copy link
Member Author

@RafaelKr, the or handles the error thrown when process-compose.is_elevated is not defined, defaulting to false.

Nix's or isn't the usual boolean operator ||, in case that's your concern.

@RafaelKr
Copy link
Contributor

Nix's or isn't the usual boolean operator ||, in case that's your concern.

@sandydoo Thanks for the clarification!
And for the fix 🎉

@RafaelKr RafaelKr mentioned this pull request Aug 27, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

process-compose sudo: exec: command not found
3 participants
@sandydoo @RafaelKr @domenkozar