Apply suggestions from code review

Co-authored-by: Matt Holt <mholt@users.noreply.github.com>

modules/caddyhttp/app.go

@@ -346,7 +346,7 @@ func (app *App) Start() error {
 					// create HTTP redirect wrapper, which detects if
 					// the request had HTTP bytes on the HTTPS port, and
 					// triggers a redirect if so.
-					ln = NewHttpRedirectListener(ln)
+					ln = &httpRedirectListener{Listener: ln}
 
 					// create TLS listener
 					tlsCfg := srv.TLSConnPolicies.TLSConfig(app.ctx)

modules/caddyhttp/httpredirectlistener.go

@@ -29,12 +29,6 @@ type httpRedirectListener struct {
 	net.Listener
 }
 
-// NewHttpRedirectListener wraps inner, handling
-func NewHttpRedirectListener(inner net.Listener) net.Listener {
-	l := &httpRedirectListener{Listener: inner}
-	return l
-}
-
 // Accept waits for and returns the next connection to the listener,
 // wrapping it with a httpRedirectConn.
 func (l *httpRedirectListener) Accept() (net.Conn, error) {