different values of MaxIdleConns and MaxIdleConnsPerHost

[akosyakov]

Maybe I'm missing something but it does not seem to be possible because keepalive_idle_conns always overrides max_idle_conns_per_host:

caddy/modules/caddyhttp/reverseproxy/httptransport.go

Lines 200 to 225 in 5ef76ff

	MaxIdleConnsPerHost: h.MaxIdleConnsPerHost,
	ResponseHeaderTimeout: time.Duration(h.ResponseHeaderTimeout),
	ExpectContinueTimeout: time.Duration(h.ExpectContinueTimeout),
	MaxResponseHeaderBytes: h.MaxResponseHeaderSize,
	WriteBufferSize: h.WriteBufferSize,
	ReadBufferSize: h.ReadBufferSize,
	}
	if h.TLS != nil {
	rt.TLSHandshakeTimeout = time.Duration(h.TLS.HandshakeTimeout)
	var err error
	rt.TLSClientConfig, err = h.TLS.MakeTLSClientConfig(ctx)
	if err != nil {
	return nil, fmt.Errorf("making TLS client config: %v", err)
	}
	}
	if h.KeepAlive != nil {
	dialer.KeepAlive = time.Duration(h.KeepAlive.ProbeInterval)
	if h.KeepAlive.Enabled != nil {
	rt.DisableKeepAlives = !*h.KeepAlive.Enabled
	}
	rt.MaxIdleConns = h.KeepAlive.MaxIdleConns
	rt.MaxIdleConnsPerHost = h.KeepAlive.MaxIdleConnsPerHost
	rt.IdleConnTimeout = time.Duration(h.KeepAlive.IdleConnTimeout)
	}

[mholt]

Hmm that does seem like an oversight, oops.

@francislavoie What if we deprecate h.MaxIdleConnsPerHost (since it's a property of keep-alive) and remove it later, since it's a bug. (I'll take care of this.)

[mholt]

Hm ok so here's what I'm gonna do: I'm just gonna remove h.MaxIdleConnsPerHost since currently, people's configs are silently broken if they specify both (since one overwrites the other). We could return an error if both are specified and the values are different, but that's still an error all the same as if we just remove it, and I'd rather delete code than add code, especially adding it just temporarily.

So, this could break some people's configs, but it fixes a bug that they're already experiencing anyway, so this will bring their configs in line to not be buggy anymore.

I'll also split keepalive_idle_conns into two options -- it took me a minute to figure out, by the way, that you were referring to Caddyfile subdirectives, @akosyakov -- leaving that one for just setting MaxIdleConns and then making keepalive_idle_conns_per_host to set MaxIdleConnsPerHost.

[mholt]

Dangit, forgot to run the tests before I pushed. Sigh...