Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented sourcing of default file for sysvinit #1984

Merged

Conversation

root360-AndreasUlm
Copy link

1. What does this change do, exactly?

It allow to overwrite the variables used in the sysvinit script by providing the file caddy in either /etc/default/ (Debian based https://www.debian.org/doc/manuals/debian-reference/ch03.en.html#_the_default_parameter_for_each_init_script ) or in /etc/sysconfig/ (CentOS based https://www.centos.org/docs/5/html/5.2/Deployment_Guide/s1-sysconfig-files.html ).

That way the server administrators can easily increase the ulimit and change installation paths if necessary.

2. Please link to the relevant issues.

None

3. Which documentation changes (if any) need to be made because of this PR?

Already documented in README

4. Checklist

  • I have written tests and verified that they fail without my change (tested on my systems)
  • I have squashed any insignificant commits (tried but got merge conflicts)
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I am willing to help maintain this change if there are issues with it later

Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
@CLAassistant
Copy link

CLAassistant commented Dec 25, 2017

CLA assistant check
All committers have signed the CLA.

Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
…AndreasUlm/caddy into implement_default_overwrite
Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no opposition to this change as far as I can see, so I'll merge it in. Thank you!

@mholt mholt merged commit 8a326d4 into caddyserver:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants