-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented sourcing of default file for sysvinit #1984
Merged
mholt
merged 9 commits into
caddyserver:master
from
root360-AndreasUlm:implement_default_overwrite
Jan 16, 2018
Merged
implemented sourcing of default file for sysvinit #1984
mholt
merged 9 commits into
caddyserver:master
from
root360-AndreasUlm:implement_default_overwrite
Jan 16, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
…AndreasUlm/caddy into implement_default_overwrite
Signed-off-by: root360-AndreasUlm <andreas.ulm@root360.de>
mholt
approved these changes
Jan 16, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no opposition to this change as far as I can see, so I'll merge it in. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this change do, exactly?
It allow to overwrite the variables used in the sysvinit script by providing the file caddy in either /etc/default/ (Debian based https://www.debian.org/doc/manuals/debian-reference/ch03.en.html#_the_default_parameter_for_each_init_script ) or in /etc/sysconfig/ (CentOS based https://www.centos.org/docs/5/html/5.2/Deployment_Guide/s1-sysconfig-files.html ).
That way the server administrators can easily increase the ulimit and change installation paths if necessary.
2. Please link to the relevant issues.
None
3. Which documentation changes (if any) need to be made because of this PR?
Already documented in README
4. Checklist