-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging: add support for hashing data #4434
Conversation
ee5ccfc
to
70de1bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for taking this on, @dunglas!
I can imagine the hash filter become more configurable (hashing algorithm, digest length) in the future, similar to what we see in the replace filter (which has the new value passed to it), for which this is a great basis. This would then also render obsolete any (subjective) concerns about the concrete values used.
I thought about that but I was wondering if it's really necessary to introduce (and maintain) such features. I fail to see a use case. |
I agree, I don't think we need to make the hashing configurable. 4 bytes is 8 hex characters, which is plenty. Git gets away with less (usually 7 chars) most of the time. |
Co-authored-by: wiese <wiese@users.noreply.github.com>
Co-authored-by: wiese <wiese@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kevin! This looks good to me.
Follows #4424, #4425 and #4426. Implements a hash filter and hash actions for the query and cookie filters ask suggested by @wiese in #4424 (comment).