Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fileserver: Add pass_thru Caddyfile option #4613

Merged
merged 1 commit into from
Mar 5, 2022
Merged

fileserver: Add pass_thru Caddyfile option #4613

merged 1 commit into from
Mar 5, 2022

Conversation

francislavoie
Copy link
Member

@francislavoie francislavoie added the feature ⚙️ New feature or request label Mar 5, 2022
@francislavoie francislavoie added this to the v2.5.0 milestone Mar 5, 2022
@francislavoie francislavoie requested a review from mholt March 5, 2022 00:52
mholt
mholt approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@mholt mholt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In practice, the file_server directive will probably need to be in a route block (or ordered using the order global option) to be useful with this mode.

@mholt mholt force-pushed the file-server-pass-thru-caddyfile branch from c19f111 to 3e4e424 Compare March 5, 2022 03:32
@francislavoie
Copy link
Member Author

Good point, we should note that in the docs.

@mholt mholt merged commit 09ba9e9 into master Mar 5, 2022
@mholt mholt deleted the file-server-pass-thru-caddyfile branch March 5, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
feature ⚙️ New feature or request
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@francislavoie @mholt