Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/cd: use the build tag nobadger to exclude badgerdb #6031

Merged
merged 2 commits into from
Jan 10, 2024
Merged

ci/cd: use the build tag nobadger to exclude badgerdb #6031

merged 2 commits into from
Jan 10, 2024

Conversation

mohammed90
Copy link
Member

@mohammed90 mohammed90 commented Jan 10, 2024 •
edited
Loading

We haven't been using BadgerDB for smallstep for a while. We're using bbolt. This PR uses the the nobadger build tag during builds and tests to exclude the badger-db implementation for https://github.com/smallstep/nosql. Our binaries used to not run on AIX; now they do! This shaves 3MB from the final binary:

-rwxr-xr-x   1 mohammed  staff  56710848 Jan 10 20:11 nobadger-caddy
-rwxr-xr-x   1 mohammed  staff  59419184 Jan 10 20:10 plain-caddy

...

-rwxr-xr-x   1 mohammed  staff    54M Jan 10 20:11 nobadger-caddy
-rwxr-xr-x   1 mohammed  staff    57M Jan 10 20:10 plain-caddy

FYI @bmarwell

@mohammed90 mohammed90 added CI/CD 🔩 Automated tests, releases dependencies ⛓️ Pull requests that update a dependency file labels Jan 10, 2024
@mohammed90 mohammed90 mentioned this pull request Jan 10, 2024
Closed
@francislavoie francislavoie added this to the v2.8.0 milestone Jan 10, 2024
@mohammed90 mohammed90 merged commit b359ca5 into master Jan 10, 2024
25 checks passed
@mohammed90 mohammed90 deleted the add-nobadger-tag branch January 10, 2024 18:04
@francislavoie francislavoie mentioned this pull request Feb 11, 2024
Draft
@emilylange emilylange mentioned this pull request May 31, 2024
Merged
13 tasks
@girlbossceo girlbossceo mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francislavoie francislavoie francislavoie approved these changes

Assignees
No one assigned
Labels
CI/CD 🔩 Automated tests, releases dependencies ⛓️ Pull requests that update a dependency file
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammed90 @francislavoie