Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fileserver: Remove newline characters from precomputed etags #6394

Merged
merged 3 commits into from
Jun 19, 2024
Merged

fileserver: Remove newline characters from precomputed etags #6394

merged 3 commits into from
Jun 19, 2024

Conversation

armadi1809
Copy link
Contributor

This PR removes newline characters from etags acquired from precomputed files as per the discussion in #6222

@francislavoie francislavoie changed the title Remove newline characters from precomputed etags fileserver: Remove newline characters from precomputed etags Jun 13, 2024
@francislavoie francislavoie added the bug 🐞 Something isn't working label Jun 13, 2024
@armadi1809 armadi1809 force-pushed the aar-trim-newline-from-etags branch from 4d3a752 to f161093 Compare June 14, 2024 23:22
@armadi1809
Copy link
Contributor Author

The replacement of the newline character is now done through bytes.ReplaceAll.

@francislavoie francislavoie added this to the v2.8.5 milestone Jun 14, 2024
mholt
mholt approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM now. I just made one quick stylistic change (IMO there's no need to convert "" to []byte, so we can just use an empty byte slice.)

@mholt mholt enabled auto-merge (squash) June 15, 2024 13:52
@mholt mholt merged commit c2ccf86 into caddyserver:master Jun 19, 2024
23 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 31, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammed90 mohammed90 mohammed90 left review comments

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
v2.8.5
Development

Successfully merging this pull request may close these issues.
4 participants
@armadi1809 @mholt @mohammed90 @francislavoie