reverseproxy: Only log host is up status on change #6419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
francislavoie
changed the title
francislavoie
changed the title
|
Thanks; this is probably still an improvement, but it would be nice to log when the host is initially discovered to be up, since active health checks should generally assume the host is down by default. That doesn't have to happen in this PR though. |
mholt
approved these changes
Jul 3, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6415
This changes the behavior of logging to only log the host up-state on state changes.
I manually tested it in the setup I needed it in and I noticed that if the upstream is available immediately the line is not logged. That leads me to believe that the event is also not emitted? I am again unsure if this is the intended behavior.
Thanks!