Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxyprotocol: Update WrapListener to use ConnPolicyFunc for PROXY protocol #6485

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

pi-prakhar
Copy link
Contributor

@pi-prakhar pi-prakhar commented Jul 29, 2024

Issue #6484

made necessary changes to maintain forward compatibility with github.com/pires/go-proxyproto

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with the changes and such but this LGTM.

@francislavoie francislavoie changed the title proxyprotocol : Update WrapListener to use ConnPolicyFunc for PROXY p… proxyprotocol: Update WrapListener to use ConnPolicyFunc for PROXY prptocol Aug 2, 2024
@francislavoie francislavoie changed the title proxyprotocol: Update WrapListener to use ConnPolicyFunc for PROXY prptocol proxyprotocol: Update WrapListener to use ConnPolicyFunc for PROXY protocol Aug 2, 2024
@mohammed90 mohammed90 linked an issue Aug 3, 2024 that may be closed by this pull request
Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this up! LGTM

@mohammed90 mohammed90 merged commit 840094a into caddyserver:master Aug 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accommodate Policy Changes in github.com/pires/go-proxyproto
4 participants