caddyhttp: Export PrivateRangesCIDR() for plugins after #6480 #6514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What if we keep it in internal for internal use but just keep a pass-through function (i.e. calling down to internal) in caddyhttp for plugin compat? That way there's no duplication of the list of IPs. |
vnxme
force-pushed
the
move-privaterangescidr-back
branch
from
4c1a432 to
07af7bd
Compare
francislavoie
approved these changes
Aug 12, 2024
francislavoie
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in mholt/caddy-l4#224, let's move PrivateRangesCIDR() back to caddyhttp and caddytls after #6480.