Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always ignore SIGPIPE #6645

Merged
merged 1 commit into from
Oct 19, 2024
Merged

fix: always ignore SIGPIPE #6645

merged 1 commit into from
Oct 19, 2024

Conversation

dunglas
Copy link
Collaborator

@dunglas dunglas commented Oct 19, 2024

Backport of dunglas/frankenphp#1101 to Caddy itself.

Sometimes (especially when using systemd), SIGPIPE signals can crash the server. This patch always ignore SIGPIPE, for all file descriptors.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the patch!

@mholt mholt merged commit b443190 into caddyserver:master Oct 19, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants