perf: remove dir redirection when useless in php_fastcgi

[dunglas]

Remove the equivalent of this config if neither {http.request.uri.path}/index.php or {path}/index.php appears in try_files, as it useless:

# Add trailing slash for directory requests
@canonicalPath {
	file {path}/index.php
	not path */
}
redir @canonicalPath {path}/ 308

This prevents one useless filesystem access on the hot path.

Similar to dunglas/frankenphp#1180.

[dunglas]

The goreleaser check failure is a false positive (because of the name of my branch)

[francislavoie]

/cc @mohammed90 re CI, I think we should set GOPROXY=direct, see golang/go#38861 (comment), or apparently GOPROXY='https://proxy.golang.org|direct' according to golang/go#32955 (comment) if we want to keep caching but I'm not sure we do want caching 😅

[mohammed90]

/cc @mohammed90 re CI, I think we should set GOPROXY=direct, see golang/go#38861 (comment)

Using GOPROXY=direct means we bypass the Go module cache completely. It's unfortunate, especially that the error is from the build flow within goreleaser/xcaddy flow. I know it breaks the workflow of some contributors, especially you @dunglas, but can't we just avoid using slashes.

I wish Go handled them instead of throwing the burden on us... 😕

[dunglas]

Yes, I'll avoid slashes. I like this convention but Go tools are totally broken when the branch name contains a slash, I always forget about that.

[mholt]

Thanks for "backporting" the optimization! 👍