Add .home.arpa to internal-only hostnames

caddyserver · Sep 5, 2023 · 6668587 · 6668587
1 parent 4fbb049
commit 6668587
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/certificates.go b/certificates.go
@@ -410,7 +410,8 @@ func SubjectIsIP(subj string) bool {
 func SubjectIsInternal(subj string) bool {
 	return subj == "localhost" ||
 		strings.HasSuffix(subj, ".localhost") ||
-		strings.HasSuffix(subj, ".local")
+		strings.HasSuffix(subj, ".local") ||
+		strings.HasSuffix(subj, ".home.arpa")
 }
 
 // MatchWildcard returns true if subject (a candidate DNS name)

diff --git a/certificates_test.go b/certificates_test.go
@@ -162,6 +162,8 @@ func TestSubjectQualifiesForPublicCert(t *testing.T) {
 		{"local", true},
 		{"foo.local", false},
 		{"foo.bar.local", false},
+		{"foo.home.arpa", false},
+		{"foo.bar.home.arpa", false},
 		{"192.168.1.3", false},
 		{"10.0.2.1", false},
 		{"169.112.53.4", false},