Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #20

Merged
merged 2 commits into from
Dec 29, 2019
Merged

update dependencies #20

merged 2 commits into from
Dec 29, 2019

Conversation

mavimo
Copy link
Member

@mavimo mavimo commented Dec 29, 2019

k8s.io/kubelet => k8s.io/kubelet v0.17.0
k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.17.0
k8s.io/metrics => k8s.io/metrics v0.17.0
k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.17.0
)
Copy link
Member

@mholt mholt Dec 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me understand why these are necessary? I looked at the linked issues but there's a lot going on in those 😅

Copy link
Member Author

@mavimo mavimo Dec 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mholt do you mean the replace section? Since K8s is moving from an outdated dependency system to go mod and they are using a single repo (that should have a single tag) but at the same time they chose to use a 0.x.y version of go mods (see kubernetes/kubernetes#84608 (comment) ) we need to explain dependencies that are reported as v0.0.0 in the kubernetes/kubernetes repo (since at the moment the reference are not updated for each release).

I don't have a background that allow me to go deep on explanation, you can find a lot of info on SIG-ARCHITECTURE https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/2019-03-19-go-modules.md

Other project follow the same approach (see -for example- https://github.com/kubernetes/ingress-nginx/blob/master/go.mod#L58-L81 )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh... that is really unusual. So this is a temporary thing, it sounds like?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mholt I hope too, but sincerely I have no idea on schedule / improvement for next releases on this side...

@mavimo mavimo requested a review from mholt December 29, 2019 20:32
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! This is exactly what needed to happen next, so I'm glad you were able to help with it!

@mholt mholt merged commit 2e31a66 into caddyserver:master Dec 29, 2019
@mavimo mavimo deleted the update-dependencies branch December 30, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants