Changed {request>user_id}
to {user_id}
#39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
{request>user_id}
used in the README of this plugin as well as in the definition ofcommonLogFormat
is not returning the value that represents"user_id": "foobar"
in the JSON access logs / the value of the placeholderhttp.auth.user.id
.I am not sure why
{request>user_id}
was used, but{user_id}
works for me in case ofbasic_auth
usage or using the new functionality described here caddyserver/caddy#6108For me,
{user_id}
instead of{request>user_id}
makes sense because theuser_id
is on the same level asts
({ts}
),status
({status}
) orsize
({size}
) as described in https://caddyserver.com/docs/logging#structured-logsThis PR fixes the README and the definition of
commonLogFormat
.