Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append command flags before arguments #223

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Append command flags before arguments #223

merged 3 commits into from
Jan 16, 2025

Conversation

YoungMind1
Copy link
Contributor

It is a janky quick fix for #222.

@mohammed90

@mohammed90
Copy link
Member

I'll check it soon. It's a critical path, and I need to pay close attention.

@mohammed90
add test
89a19a2 
Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
@mohammed90
refactor newGoBuildCommand
44ae330 
Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
@mohammed90 mohammed90 added the bug Something isn't working label Jan 16, 2025
@mohammed90 mohammed90 linked an issue Jan 16, 2025 that may be closed by this pull request
XCADDY_GO_BUILD_FLAGS is not behaving well with windows builds #222
Closed
mohammed90
mohammed90 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this! Your changes helped me see where our model was slightly wrong, so I built atop your work and refactored the method. It also helps making it testable.

@mohammed90 mohammed90 merged commit 3339110 into caddyserver:master Jan 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammed90 mohammed90 mohammed90 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XCADDY_GO_BUILD_FLAGS is not behaving well with windows builds
2 participants
@YoungMind1 @mohammed90