Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change registry Apis signature to return info interface #1355

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

ketsiambaku
Copy link
Contributor

@ketsiambaku ketsiambaku commented Jul 4, 2024

Detailed Description
[In-depth description of the changes made to the interfaces, specifying new fields, removed fields, or modified data structures]

Change in signature on the following WorkflowRegistry methods:
GetWorkflowFunc
GetRegisteredWorkflows

the two methods are combined into one where GetRegisteredWorkflows now returns an RegistryInfo interface. The info interface exposes methods to retrieve the function and workflow info.

The same goes for the ActivityRegistry methods:
GetActivityFunc
GetRegisteredActivities

Impact Analysis

  • Backward Compatibility: [Analysis of backward compatibility]
  • Forward Compatibility: [Analysis of forward compatibility]

Testing Plan

  • Unit Tests: [Do we have unit test covering the change?] Yes
  • Persistence Tests: [If the change is related to a data type which is persisted, do we have persistence tests covering the change?]
  • Integration Tests: [Do we have integration test covering the change?]
  • Compatibility Tests: [Have we done tests to test the backward and forward compatibility?]

Rollout Plan

  • What is the rollout plan?
  • Does the order of deployment matter?
  • Is it safe to rollback? Does the order of rollback matter? Safe to roll back. No required order
  • Is there a kill switch to mitigate the impact immediately?

@ketsiambaku ketsiambaku merged commit c032df0 into cadence-workflow:master Jul 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants