Fix ActivityCompletionClient cancellation and failure by WorkflowExecution #930
Conversation
natemort
requested review from
Groxx,
abhishekj720,
shijiesheng,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 2563Details
💛 - Coveralls |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -0,0 +1,249 @@ | |||
| /* | |||
| * Copyright 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
oh, I didn't see the "modifiications copyright" down below, I guess it is from there. the licence URL looks sus, but I guess it is what it is.
There was a problem hiding this comment.
The cadence java client is a fork of https://github.com/aws/aws-swf-flow-library 😄
| testRule.newWorkflowStub(ManualCompletionWorkflow.class).run(); | ||
| } | ||
|
|
||
| public interface ManualCompletionActivities { |
There was a problem hiding this comment.
nonblocking / question: So, forgive my utter ignorance of testing in Java, but why declare an interface here?
natemort
force-pushed
the
manual
branch
2 times, most recently
from
255d591
to
926be8a
Compare
…ution When sending RespondActivityTaskFailedByIDRequest or RespondActivityTaskCanceledByIDRequest we don't include the ActivityID. Correctly include the id and add test coverage.
When sending RespondActivityTaskFailedByIDRequest or RespondActivityTaskCanceledByIDRequest we don't include the ActivityID. Correctly include the id and add test coverage.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes