Fix startTime in workflow task refresher (#4488)

cadence-workflow · Sep 13, 2021 · 3e3bb67 · 3e3bb67
1 parent 9e99272
commit 3e3bb67
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 9 deletions.
diff --git a/service/history/execution/mutable_state_task_refresher.go b/service/history/execution/mutable_state_task_refresher.go
@@ -41,7 +41,7 @@ var emptyTasks = []persistence.Task{}
 type (
 	// MutableStateTaskRefresher refreshes workflow transfer and timer tasks
 	MutableStateTaskRefresher interface {
-		RefreshTasks(ctx context.Context, mutableState MutableState) error
+		RefreshTasks(ctx context.Context, startTime time.Time, mutableState MutableState) error
 	}
 
 	mutableStateTaskRefresherImpl struct {
@@ -76,6 +76,7 @@ func NewMutableStateTaskRefresher(
 
 func (r *mutableStateTaskRefresherImpl) RefreshTasks(
 	ctx context.Context,
+	startTime time.Time,
 	mutableState MutableState,
 ) error {
 
@@ -88,6 +89,7 @@ func (r *mutableStateTaskRefresherImpl) RefreshTasks(
 
 	if err := r.refreshTasksForWorkflowStart(
 		ctx,
+		startTime,
 		mutableState,
 		taskGenerator,
 	); err != nil {
@@ -173,6 +175,7 @@ func (r *mutableStateTaskRefresherImpl) RefreshTasks(
 
 func (r *mutableStateTaskRefresherImpl) refreshTasksForWorkflowStart(
 	ctx context.Context,
+	startTime time.Time,
 	mutableState MutableState,
 	taskGenerator MutableStateTaskGenerator,
 ) error {
@@ -183,7 +186,7 @@ func (r *mutableStateTaskRefresherImpl) refreshTasksForWorkflowStart(
 	}
 
 	if err := taskGenerator.GenerateWorkflowStartTasks(
-		time.Unix(0, startEvent.GetTimestamp()),
+		startTime,
 		startEvent,
 	); err != nil {
 		return err

diff --git a/service/history/execution/mutable_state_task_refresher_mock.go b/service/history/execution/mutable_state_task_refresher_mock.go
diff --git a/service/history/execution/state_rebuilder.go b/service/history/execution/state_rebuilder.go
@@ -185,7 +185,7 @@ func (r *stateRebuilderImpl) Rebuild(
 	}
 
 	// refresh tasks to be generated
-	if err := r.taskRefresher.RefreshTasks(ctx, rebuiltMutableState); err != nil {
+	if err := r.taskRefresher.RefreshTasks(ctx, now, rebuiltMutableState); err != nil {
 		return nil, 0, err
 	}
 

diff --git a/service/history/execution/state_rebuilder_test.go b/service/history/execution/state_rebuilder_test.go
@@ -304,7 +304,7 @@ func (s *stateRebuilderSuite) TestRebuild() {
 		1234,
 		s.mockClusterMetadata,
 	), nil).AnyTimes()
-	s.mockTaskRefresher.EXPECT().RefreshTasks(gomock.Any(), gomock.Any()).Return(nil).Times(1)
+	s.mockTaskRefresher.EXPECT().RefreshTasks(gomock.Any(), now, gomock.Any()).Return(nil).Times(1)
 
 	rebuildMutableState, rebuiltHistorySize, err := s.nDCStateRebuilder.Rebuild(
 		context.Background(),

diff --git a/service/history/historyEngine.go b/service/history/historyEngine.go
@@ -3276,7 +3276,7 @@ func (e *historyEngineImpl) RefreshWorkflowTasks(
 		e.shard.GetShardID(),
 	)
 
-	err = mutableStateTaskRefresher.RefreshTasks(ctx, mutableState)
+	err = mutableStateTaskRefresher.RefreshTasks(ctx, mutableState.GetExecutionInfo().StartTimestamp, mutableState)
 	if err != nil {
 		return err
 	}