Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new matching and frontend API to get all tasklists for a domain #4175

Merged
merged 32 commits into from
Jul 1, 2021

Conversation

anish531213
Copy link
Contributor

What changed?
Introduced new API called GetTaskListForDomain to get all tasklists for a domain. For this introduced a cache in matching engine that keeps track of tasklist and domain relation.

Why?
Introduced this API so this can be used to get granular tasklist information for a domain. This is planned to be used in failover manager but can have other uses in the future.

How did you test it?
Just introduced this API. Will add the unit test and verify in staging eng.

Potential risks
I don't see any potential risks.

Release notes

Documentation Changes

@anish531213 anish531213 requested review from a team and yux0 May 6, 2021 17:59
@anish531213 anish531213 force-pushed the aanish/gettasklistfordomain branch from fb04588 to dfcb956 Compare May 6, 2021 18:46
client/frontend/client.go Outdated Show resolved Hide resolved
service/matching/handler.go Outdated Show resolved Hide resolved
service/matching/matchingEngine.go Outdated Show resolved Hide resolved
common/clientCache.go Outdated Show resolved Hide resolved
client/matching/client.go Outdated Show resolved Hide resolved
client/matching/client.go Outdated Show resolved Hide resolved
service/matching/matchingEngine.go Outdated Show resolved Hide resolved
service/matching/matchingEngine.go Outdated Show resolved Hide resolved
service/matching/matchingEngine.go Outdated Show resolved Hide resolved
service/matching/matchingEngine.go Outdated Show resolved Hide resolved
client/matching/client.go Outdated Show resolved Hide resolved
@anish531213 anish531213 force-pushed the aanish/gettasklistfordomain branch from eccce46 to a109696 Compare May 18, 2021 17:30
common/clientCache.go Outdated Show resolved Hide resolved
common/clientCache.go Outdated Show resolved Hide resolved
service/matching/matchingEngine.go Outdated Show resolved Hide resolved
service/matching/matchingEngine.go Outdated Show resolved Hide resolved
@anish531213 anish531213 force-pushed the aanish/gettasklistfordomain branch from aef3e06 to 3ce0ecb Compare May 20, 2021 21:51
@anish531213 anish531213 force-pushed the aanish/gettasklistfordomain branch from b8ae2b3 to ddcd973 Compare May 21, 2021 18:31
@yux0 yux0 requested a review from a team June 24, 2021 22:50
client/matching/client.go Outdated Show resolved Hide resolved
client/matching/client.go Outdated Show resolved Hide resolved
common/clientCache.go Outdated Show resolved Hide resolved
client/matching/client.go Outdated Show resolved Hide resolved
service/matching/config.go Outdated Show resolved Hide resolved
service/matching/matchingEngine.go Outdated Show resolved Hide resolved
service/matching/matchingEngine.go Outdated Show resolved Hide resolved
service/matching/matchingEngine.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 29, 2021

Pull Request Test Coverage Report for Build 5fc838bb-62da-4263-a3cf-8f71f784dcc0

  • 88 of 420 (20.95%) changed or added relevant lines in 29 files are covered.
  • 25 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.08%) to 59.796%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client/frontend/grpcClient.go 0 4 0.0%
client/frontend/thriftClient.go 0 4 0.0%
client/matching/grpcClient.go 0 4 0.0%
client/matching/thriftClient.go 0 4 0.0%
service/frontend/grpcHandler.go 0 4 0.0%
service/frontend/thriftHandler.go 0 4 0.0%
service/matching/grpcHandler.go 0 4 0.0%
service/matching/thriftHandler.go 0 4 0.0%
common/types/matching.go 0 5 0.0%
client/frontend/retryableClient.go 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 74.4%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/queue/timer_queue_processor.go 2 58.77%
service/history/task/fetcher.go 2 77.18%
service/matching/matcher.go 2 91.46%
service/history/execution/mutable_state_builder.go 4 69.81%
service/history/queue/processor_base.go 4 62.84%
service/history/task/transfer_active_task_executor.go 4 69.73%
service/history/task/transfer_standby_task_executor.go 4 90.42%
Totals Coverage Status
Change from base Build b88326a2-a334-4463-9bcc-2a0ee5f3bb3c: -0.08%
Covered Lines: 90412
Relevant Lines: 151201

💛 - Coveralls

client/matching/client.go Outdated Show resolved Hide resolved
common/types/mapper/proto/matching.go Show resolved Hide resolved
common/types/mapper/thrift/shared.go Show resolved Hide resolved
service/matching/config.go Outdated Show resolved Hide resolved
service/matching/matchingEngine.go Outdated Show resolved Hide resolved
service/matching/matchingEngine.go Outdated Show resolved Hide resolved
service/matching/matchingEngine.go Outdated Show resolved Hide resolved
service/frontend/thriftHandler.go Outdated Show resolved Hide resolved
service/matching/thriftHandler.go Outdated Show resolved Hide resolved
Copy link
Contributor

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Feel free to land after addressing the rest of the comments (withThriftTag, ctx timeout, and mapper tests).

client/matching/client.go Outdated Show resolved Hide resolved
client/matching/client.go Outdated Show resolved Hide resolved
client/matching/client.go Outdated Show resolved Hide resolved
@yux0 yux0 merged commit 94b2405 into cadence-workflow:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants