-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new matching and frontend API to get all tasklists for a domain #4175
Merged
yux0
merged 32 commits into
cadence-workflow:master
from
anish531213:aanish/gettasklistfordomain
Jul 1, 2021
Merged
Implement new matching and frontend API to get all tasklists for a domain #4175
yux0
merged 32 commits into
cadence-workflow:master
from
anish531213:aanish/gettasklistfordomain
Jul 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anish531213
force-pushed
the
aanish/gettasklistfordomain
branch
from
May 6, 2021 18:46
fb04588
to
dfcb956
Compare
yux0
reviewed
May 10, 2021
yycptt
reviewed
May 11, 2021
anish531213
force-pushed
the
aanish/gettasklistfordomain
branch
from
May 18, 2021 17:30
eccce46
to
a109696
Compare
yux0
reviewed
May 19, 2021
yux0
reviewed
May 20, 2021
anish531213
force-pushed
the
aanish/gettasklistfordomain
branch
from
May 20, 2021 21:51
aef3e06
to
3ce0ecb
Compare
yux0
reviewed
May 21, 2021
yux0
approved these changes
May 21, 2021
anish531213
force-pushed
the
aanish/gettasklistfordomain
branch
from
May 21, 2021 18:31
b8ae2b3
to
ddcd973
Compare
yycptt
reviewed
Jun 24, 2021
yycptt
reviewed
Jun 29, 2021
yycptt
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Feel free to land after addressing the rest of the comments (withThriftTag, ctx timeout, and mapper tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Introduced new API called GetTaskListForDomain to get all tasklists for a domain. For this introduced a cache in matching engine that keeps track of tasklist and domain relation.
Why?
Introduced this API so this can be used to get granular tasklist information for a domain. This is planned to be used in failover manager but can have other uses in the future.
How did you test it?
Just introduced this API. Will add the unit test and verify in staging eng.
Potential risks
I don't see any potential risks.
Release notes
Documentation Changes