Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing activity failure details in standby cluster #4323

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Jul 22, 2021

What changed?

  • Fix missing activity failure details in standby cluster

Why?

  • Currently activity failure details is not applied in standby cluster

How did you test it?

  • Tested locally.

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested review from yux0 and a team July 22, 2021 23:24
@coveralls
Copy link

coveralls commented Jul 22, 2021

Pull Request Test Coverage Report for Build 0bbeb52e-b5a0-4124-8736-d3aeeaec3f6b

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 129 unchanged lines in 24 files lost coverage.
  • Overall coverage decreased (-0.05%) to 56.78%

Files with Coverage Reduction New Missed Lines %
common/persistence/sql/sqlExecutionStore.go 1 61.07%
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
client/history/client.go 2 40.34%
client/history/metricClient.go 2 47.05%
common/persistence/executionManager.go 2 75.75%
common/persistence/statsComputer.go 2 96.43%
common/task/parallelTaskProcessor.go 2 92.48%
common/types/mapper/thrift/shared.go 2 64.98%
service/history/execution/mutable_state_builder.go 2 69.92%
service/history/handler.go 2 46.05%
Totals Coverage Status
Change from base Build f00235ee-84e3-469e-92d9-91820b04763a: -0.05%
Covered Lines: 77850
Relevant Lines: 137107

💛 - Coveralls

@yycptt yycptt merged commit bec009a into cadence-workflow:master Jul 23, 2021
@yycptt yycptt deleted the sync-activity-failure-details branch July 23, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants